-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide hostname for SNI #15
Comments
Absolutely agree. I'd like to see hostname and ALPN accepted as arguments. For background, we very intentionally limited the options that can be specified on I think it is safe to say, however, that |
Definitely -- both of those may be required for a successful HTTP/2 or gRPC connection, for example. In terms of TLS options, I'd suggest these are probably the two most important and most common. |
Would you be interested in opening a PR adding these? I think we ought to be able to keep it pretty simple, e.g.,
|
This has been added. |
The hostname negotiation for SNI may be different from the connection address. For example, a client may connect by IP to a service and provide an unresolved hostname on connection. As in #14, this SNI negotation result may need to provided as part of the handshake promise.
The text was updated successfully, but these errors were encountered: