Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug:Object Data Type Arguments in Schedule Not Loading in Edit Screen #5066

Closed
nstokes-blossom opened this issue Jan 15, 2025 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@nstokes-blossom
Copy link

Describe the bug

When a schedule pointed to a script or flow contains an "object" data type argument, the value of that object is not pulling when attempting to view or edit the schedule through the supported GUI. The argument values continue to parse into the scheduled execution, and returns when using the windmill CLI/API to return the argument values, just not within the GUI application.

To reproduce

  1. Create or Fork a Script that takes a data object as an input value (I used hub/1468/helper/convert_javascript_object_to_json_string).
  2. Create a new schedule which points to the newly created/forked script or flow (if using my example, this is a script).
  3. Create a default scheduling value for the "object" data type (if using my example, this argument is titled "value"). Additionally make an indication of a non-object data type to see that other values are returning (in my example it is the "indentation" boolean argument).
  4. Click "save" and then attempt to view or review the newly created schedule. You will see that no value is returned for the "object" data type arguments, but seems to return for other values.
  5. If you wished to setup an instance that uses no "object" data types as arguements, you can use the hub/3038/windmill/get_schedule script, which contains two string input parameters.

Expected behavior

I would expect the "object" data type arguments that are saved with a schedule to be returned when viewing the schedule so it can either be referenced by a user or modified by a user with ease. We see this exist with other data types used as arguments (booleans, strings, integers, etc.), I believe this functionality should extend to "object" data types as well.

Screenshots

Non-Working Iteration with Object Argument
image

Non-Working Schedule Pulled from Windmill CLI/API
image

Working Iteration with String Arguments
image

Browser information

Google Chrome v131.0.6778.205

Application version

CE v1.444.0-1-ge47a3aa7c

Additional Context

No response

@nstokes-blossom nstokes-blossom added the bug Something isn't working label Jan 15, 2025
@rubenfiszel
Copy link
Contributor

Thanks for the report, we will fix it in a few hours

@rubenfiszel
Copy link
Contributor

Should be fixed in 1.447.2, available in 30mins

@nstokes-blossom
Copy link
Author

I can confirm that the 1.447.2 version now returns object data type values for the associated schedules!

Screenshot of working iteration:
image

Thank you very much for the expeditious review and correction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants