Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow preprocessor to write to args.json on nsjail #4455

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Sep 27, 2024

Important

Allow args.json to be writable in run.bun.config.proto and run.python3.config.proto by setting rw: true.

  • Behavior:
    • Allow args.json to be writable by setting rw: true in run.bun.config.proto and run.python3.config.proto.
  • Files:
    • run.bun.config.proto: Updated mount for args.json to be writable.
    • run.python3.config.proto: Updated mount for args.json to be writable.

This description was created by Ellipsis for 9c3974c. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9c3974c in 9 seconds

More details
  • Looked at 25 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. backend/windmill-worker/nsjail/run.bun.config.proto:123
  • Draft comment:
    Ensuring rw: true for args.json is necessary for allowing write operations, which aligns with the PR's intent to enable the preprocessor to write to this file.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change to make the args.json file writable is consistent across both configurations. This is necessary for the preprocessor to write to the file, as per the PR title. The change seems correct and intentional.
2. backend/windmill-worker/nsjail/run.python3.config.proto:84
  • Draft comment:
    Ensuring rw: true for args.json is necessary for allowing write operations, which aligns with the PR's intent to enable the preprocessor to write to this file.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change to make the args.json file writable is consistent across both configurations. This is necessary for the preprocessor to write to the file, as per the PR title. The change seems correct and intentional.

Workflow ID: wflow_e9rE9v9rTlNams7E


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c3974c
Status: ✅  Deploy successful!
Preview URL: https://f0f40ef8.windmill.pages.dev
Branch Preview URL: https://hc-preprocessor-nsjail.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 0b9ec83 into main Sep 27, 2024
3 checks passed
@rubenfiszel rubenfiszel deleted the hc/preprocessor-nsjail branch September 27, 2024 19:12
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants