scripts file content within flow replaced by !inline script_name.inline_script.bun.ts

[whollacsek]

1. Open a flow.yaml file
2. Show preview
3. Click on a script node in the preview

• All .lock files get deleted
• All script file content get replaced by !inline script_name.inline_script.bun.ts

[rubenfiszel]

It's intended, the CLI and vscode work with the assumption that locally it is better to use separate files for lock and content file. The new files should have been created as well no?

I agree it is a bit aggressive, we could make that an option if desired but in general I prefer having a unique behavior so that there aren't too many alternatives mode to maintain.

[whollacsek]

Hi Ruben, thanks for the prompt reply. I'm not sure if I understand the expected behavior fully, but in my case what happens is all the local .lock files are deleted when I click on a node in the preview, and the content of all the .bun.ts files are replaced by !inline file_name.bun.ts, meaning the code is lost forever (flow.yaml does not contain the code either). When I `wmill sync pull` I do get the .lock files. I downloaded the vscode extension today and I updated my windmill instance as well to 1.330

…

On Wed, 15 May 2024 at 14:24, Ruben Fiszel ***@***.***> wrote: It's intended, the CLI and vscode work with the assumption that locally it is better to use separate files for lock and content file. The new files should have been created as well no? I agree it is a bit aggressive, we could make that an option if desired but in general I prefer having a unique behavior so that there aren't too many alternatives mode to maintain. — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGJQUFATXXYVWECWKKXQMDZCNO2XAVCNFSM6AAAAABHYFKRACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGUYTSOBZG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rubenfiszel]

Are the files (here: script_name.inline_script.bun.ts) created as well, with the content inlined ? If not, that's probably something we ought to improve

[rubenfiszel]

but just for the record, the intended usage is that you use the cli to pull from your workspace. The CLI will pull the flow folder with the correct layout and splitted files.

[whollacsek]

Yes the CLI pull is correct with the expected layout (each script with their own .bun.ts files and .lock files) but once I click on a node in the preview pane the folder layout is changed and the file `script_name.inline_script.bun.ts` is modified to literally contain only one line: `!inline script_name.inline_script.bun.ts` which means my code is lost. Since the content field of the flow.yaml is already `!inline script_name.inline_script.bun.ts`, I think the script file content should not be replaced, just kept as is.

…

On Wed, 15 May 2024 at 15:08, Ruben Fiszel ***@***.***> wrote: but just for the record, the intended usage is that you use the cli to pull from your workspace. The CLI will pull the flow folder with the correct layout and splitted files. — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGJQUGYKKLBHOCZVXBK62TZCNT7VAVCNFSM6AAAAABHYFKRACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSGY2TIMZVGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[rubenfiszel]

I understand now. Can you check if you are on the latest version of the vscode extension ? Otherwise could you share a minimal flow that expose this behavior. I do not face it locally

[whollacsek]

I think the issue was related to missing script paths, it's something I manually fixed then pushed so unfortunately I can not reproduce it at the moment.

…

On Wed, 15 May 2024 at 15:52, Ruben Fiszel ***@***.***> wrote: I understand now. Can you check if you are on the latest version of the vscode extension ? Otherwise could you share a minimal flow that expose this behavior. I do not face it locally — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGJQUEEXX7HQK3CPWOIZUTZCNZBBAVCNFSM6AAAAABHYFKRACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJSG42TSNRYHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>