-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with links from Full Screen apps and multiple workspaces/desktops (need to restart app frequently) #595
Comments
Thanks for the bug report. I think this has happened before, some sort of Electron limitation, I can't remember. Anyway, I'll mark it as "help wanted" as I don't fullscreen apps 🙂 |
I have had this same issue on and off for a long time, but in the last week or see it seems to have really ramped up how often this occurs. @will-stone do you remember anything about how it happened before to help figure out which direction to go in? |
Sorry, no. There may be some clue in searching the issues but nothing off the top of my head, no. |
I have occasionally noticed this in the rare times I use full screen mode, but if I observe an obvious pattern and have a hunch I'd be happy to discuss it further here and potentially think of a solution or PR |
I do fullscreen apps every day and can say that I've been seeing this issue more and more lately. Perhaps since updating to Ventura. I didn't know this was happenning specifically with fullscreen apps, so I'll try to not fullscreen them and check if I see it again. |
Looks related: electron/electron#36364 |
This is occurring for applications that are not in fullscreen mode as well. The only workaround is to quit and re-open browserosaurus. |
@jishnu7 Are you using virtual desktops? Please note, I do not maintain the code for the underlying framework, Electron. If you'd really like to help, please add reproducible examples to the issue on their tracker: electron/electron#36364 Thank you |
This comment was marked as duplicate.
This comment was marked as duplicate.
I did dig deep and found reproducible steps.
|
Thanks @jishnu7 Now if you could boil that down to a very simple reproducible example for the Electron project, that would be awesome 😎 I use neither virtual desktops nor full screen apps so this will never be a priority for me 👍 |
What do you mean by example for the electron project? If you can share some pointers, I might be able to help on that. |
@jishnu7 Your best bet is probably to use Electron Fiddle to make a reproducible example, you can then publish that and post it as an issue on the Electron repo 🙂 👍 |
This comment was marked as duplicate.
This comment was marked as duplicate.
Same problem here |
@ will-stone, you could restart the App automatically every 15 minutes (make it a parameter) to solve this (temporarily). What do you think? |
Sorry, that doesn’t sound like a good idea. The best solution is for someone to create a small reproducible example and submit to Electron. |
I see this issue also. or a variant at least. If I have an application like Outlook, with a link in one of the email, the expected behaviour is to click on the link and to get the menu choice of which browser to open the link in. Having restarted Browsersaurus, that happens. However, after a period of time (varies) one of two things happens:
A reboot of Browsersaurus resolves the issue. Until it re-occurs. To me it feels like there might be an issue with the browser requested being on a different desktop to the application where the ink menu is triggered, so in effect it can't fine the target and fails. I'm on the latest Mac OS and latest patch. Any assistance in fixing this would be much appreciated as this is a really killer application :-) |
Indeed! 😄 Create a reproducible minimal example, and send it to the Electron project. Please only update the issue if you can provide more information than has already been gleaned above: there will be quite a few people watching this now, and every time a new post is made they will be notified and disappointed it is not progression. Thanks 🙂 |
It seems fixed after upgrade to Ventura 13.2.1... Will see after some time. Will update if issue will appears again |
I was still seeing this issue on |
Just for reference: #175. Seems like same issue resolved in the past |
I'm using multiple desktops daily, so this is critical for me. As a workaround - I've downgraded to https://github.com/will-stone/browserosaurus/releases/tag/v19.3.3 and blocked network access for the app, so it can't auto upgrade - testing. Update: doesn't work also 😢 |
I've been dealing with this for a long time, so I've added this to my crontab (
It will kill Browserosaurus every 3 minutes, the next time you click a link, it will simply take a little bit longer to start, but it mitigates the problem altogether. A fix for this would be appreciated, though, as it may take few seconds to start Browserosaurus and opening links has become a PITA. Thanks for the app anyways, Mac OS wouldn't be usable for me without it ❤️ |
Regarding the "assign app to spaces" solution @kopach suggested, while it does not work with the main app, it does work if you drag the embedded "Browserosaurus Helper" to the dock and assign to all spaces. |
Where is that helper ? Couldn't find it inside app package. |
@mrdavemorgan , I'm also curious how you did that. By "Browserosaurus Helper" do you mean this small popup window with browsers list? how have you dragged it into dock? I can't drag it :( |
@sushione , ok, I guess, I've found it. You have to find "Browserosaurus.app" (under /Applications), right click and select "Show Package Contents". Then navigate to Contents -> Frameworks. You will find "Browserosaurus Helper" there which you can drag into Dock and change window options. |
Apple M1 "Browserosaurus Helper" - works, but it's an ugly solution :( |
This comment was marked as duplicate.
This comment was marked as duplicate.
@will-stone sorry if this has been asked before, but does browserosaurus need to run in background? is there a reason it can't just spawn when asking for a browser then entirely exit when done? I believe that this would fix this issue by proxy, which would be good because I can't use this excellent program as soon as I go into a fullscreen youtube video |
Using this option fixes will-stone#595 by proxy of spawning a new instance on the current desktop. I imagine cleaning up Browserosaurus can also help conserve memory usage on those systems with little of it, at the cost of startup time. Keep in mind if this option is set during development, Browserosaurus *will* exit and you'll have to restart it on the command line to use it as the default HTTP handler; but in production this would seamlessly spin up the app when the user clicks a link. This returns a promise from `openApp` which could perhaps be used for more extensive error handling in the future.
B’s first load is quite slow. I don’t think this would be a viable solution. Unless someone knows how to fix this issue upstream, and you need full screen support, I’d suggest using Velja by Sindre Sorhus for now. |
I've been waiting for a fix too long, so i written SwiftUI port today. Still testing, but at least this bug seems to be fixed. |
@AlexStrNik this is great (not that I’ve tested it), and I would have switched to Swift too if I had the know-how (by that I mean: I am a TS engineer by trade, and recently became a father, so do not currently have the time or energy to learn a new language). May I please suggest that you carve out your own identity for the app? For example, the readme could highlight what it does and how to use it, rather than simply dunking on Browserosaurus. I know it’s early days for Browserino, and you probably just wanted to get something up to show people quickly, but let’s respect each other’s efforts. This project has been provided for free for seven years. |
Hey @will-stone! Sorry, never meant to disrespect you or your app. Was a little bit busy on job to write good Readme but wanted to already share. I changed description in the repository. P.S I'm too web developer at my position. Changed my thoughts about typescript a lot after learning Swift) |
And a screenshot, that looks great 😄 Out of interest, which do you prefer, TS or Swift? |
Swift type system much better as for me, although it not so powerful so you cant write compile time spell checking, but i really missing Swift enums with associated values in other languages. And there something similar between TS and Swift, sometimes when expression is complex enough it fails to derive types :) |
@AlexStrNik Would you like to submit your app to "Notable Forks" section of README: https://github.com/will-stone/browserosaurus?tab=readme-ov-file#notable-forks Feel free to change the title of that section too, maybe |
If you don't mind, so I would. Maybe later this week, a little busy now |
I just installed 20.8.0 on MacOS 14.4.1, and I don't have the issue anymore. I can open the links from any workspace even if it is a fullscreen VS Code. Browserosorous work just fine, the prompt appears on any screen/workspace you're on. thanks guys I love this tool :) If this issue still needs help, I'll be happy to dive into code. Let me know, thanks. |
I've just tested this on Sonoma on latest B (v20.9.0) and it seems to be fixed. Can anyone on Sonoma confirm? (Any other version of macOS isn't officially supported). |
Cool, going to mark this as closed. Please let me know if you still have an issue and we'll reopen. |
@will-stone this is fixed for me on 14.6 (23G80) running 20.8.0. thank you 👍 |
Reopening 😭 |
Yeah, I was coming here to see if there was a fix. I'm seeing the behavior now almost exclusively from Slack trying to open links. I'm on v20.9.1 of Browserosaurus, Version 4.41.97 of Slack and macOS Sequoia 15.1 (and I think this literally started when I updated to 15.1). It's absolutely mesmerizing to me that this has worked so well, for so long! Congrats @will-stone on becoming a father! Best of luck with trying to juggle everything. I've been there, done that, and it's one of the hardest, but most rewarding things you'll ever do! |
Is there an existing issue for this?
Current Behaviour
I use apps in Full screen mode on macOS Ventura 13.0.1. When Browserosaurus app starts, clicking links in the full-screen apps works. The Browser selection overlay shows up on the full screen app.
After sometime (indeterminate) when I click on a link in a full screen app, the space changes to the Desktop and Browserosaurus selection overlay shows up for a split second and disappears.
Browserosaurus.Bug.mov
Expected Behaviour
The Browser selection overlay should show on the Full screen app and allow me to tap on a Browser.
Steps To Reproduce
Browserosaurus version
19.3.3
macOS version
13.0.1
CPU Architecture
ARM
Anything else?
No response
The text was updated successfully, but these errors were encountered: