Merge pull request #173 from wmde/rel0145

Fix broken ExpertExtender.CalendarHint.tests

Author: filbertkm

README.md

@@ -105,6 +105,9 @@ Other methods an `Expert` needs to provide:
 
 ## Release notes
 
+### 0.14.5 (2015-06-11)
+* Fixed `jQuery.valueview.ExpertExtender.CalendarHint` test broken due to DataValues JavaScript dependency update.
+
 ### 0.14.4 (2015-06-10)
 * Added expert for `UnDeserializableValue`s.
 * Updated DataValues JavaScript dependency to version 0.7.
@@ -143,7 +146,7 @@ Other methods an `Expert` needs to provide:
 * Introduced `utils.ContentLanguages`
 
 #### Breaking changes
-* `ExpertExtender.LanguageSelector` constructor requires `utils.ContentLanguages` now
+* `jQuery.valueview.ExpertExtender.LanguageSelector` constructor requires `utils.ContentLanguages` now.
 
 ### 0.11.0 (2015-01-21)
 * `jQuery.ui.toggler`: Added parameter to `animation` event determining whether the toggler's subject will be visible or hidden.

ValueView.php

@@ -5,7 +5,7 @@
 	return 1;
 }
 
-define( 'VALUEVIEW_VERSION', '0.14.4' );
+define( 'VALUEVIEW_VERSION', '0.14.5' );
 
 /**
  * @deprecated

tests/src/ExpertExtender/ExpertExtender.CalendarHint.tests.js

@@ -87,15 +87,15 @@
 		);
 		var $extender = $( '<div />' ).appendTo( 'body' ) ;
 
-		assert.equal( timeValue.calendar(), 'Gregorian' );
+		assert.equal( timeValue.getOption( 'calendarModel' ), 'http://www.wikidata.org/entity/Q1985727' );
 
 		calendarHint.init( $extender );
 		calendarHint.draw();
 
 		$( '.valueview-expertextender-calendarhint-switch', $extender[0] ).click();
 
 		sinon.assert.calledOnce( setSpy );
-		assert.equal( setSpy.firstCall.args[0], 'Julian' );
+		assert.equal( setSpy.firstCall.args[0], 'http://www.wikidata.org/entity/Q1985786' );
 
 		$extender.remove();
 	} );
@@ -123,7 +123,7 @@
 		$( '.valueview-expertextender-calendarhint-switch', $extender[0] ).click();
 
 		sinon.assert.calledOnce( setSpy );
-		assert.equal( setSpy.firstCall.args[0], 'Julian' );
+		assert.equal( setSpy.firstCall.args[0], 'http://www.wikidata.org/entity/Q1985786' );
 
 		timeValue = new TimeValue( timeValue.toJSON().time, {
 			calendarModel: TimeValue.CALENDARS.JULIAN,
@@ -134,7 +134,7 @@
 		$( '.valueview-expertextender-calendarhint-switch', $extender[0] ).click();
 
 		sinon.assert.calledTwice( setSpy );
-		assert.equal( setSpy.secondCall.args[0], 'Gregorian' );
+		assert.equal( setSpy.secondCall.args[0], 'http://www.wikidata.org/entity/Q1985727' );
 
 		$extender.remove();
 	} );