Skip to content

Commit 10b1056

Browse files
committed
Merge pull request #187 from wmde/characteristicsTests
Fix outdated QuantityInput.tests
2 parents 1f57969 + 2e08863 commit 10b1056

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,9 @@ Other methods an `Expert` needs to provide:
105105

106106
## Release notes
107107

108+
### 0.15.3 (2015-08-27)
109+
* Fixed `jQuery.valueview.experts.QuantityInput` test.
110+
108111
### 0.15.2 (2015-08-27)
109112

110113
#### Enhancements

ValueView.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
return 1;
66
}
77

8-
define( 'VALUEVIEW_VERSION', '0.15.2' );
8+
define( 'VALUEVIEW_VERSION', '0.15.3' );
99

1010
// Include the composer autoloader if it is present.
1111
if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {

tests/src/experts/QuantityInput.tests.js

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,29 @@
3434
'unit is null or a string'
3535
);
3636

37+
assert.ok(
38+
!characteristics.hasOwnProperty( 'applyUnit' ),
39+
'applyUnit does not exist'
40+
);
41+
42+
assert.ok(
43+
!characteristics.hasOwnProperty( 'applyRounding' ),
44+
'applyRounding does not exist'
45+
);
46+
} );
47+
48+
QUnit.test( 'valueCharacteristics( \'text/plain\' )', function( assert ) {
49+
var expert = newExpert(),
50+
characteristics = expert.valueCharacteristics( 'text/plain' );
51+
3752
assert.ok(
3853
characteristics.applyUnit === false,
39-
'applyUnit must be false'
54+
'applyUnit is false'
4055
);
4156

4257
assert.ok(
4358
characteristics.applyRounding === false,
44-
'applyRounding must be false'
59+
'applyRounding is false'
4560
);
4661
} );
4762

0 commit comments

Comments
 (0)