Drop support for ruby 2.4.x (#407)

* updated gemspec ruby version to >2.4, updated README

* removing checks for ruby 2.4 in travis scripts

* removed ruby 2.4 from github actions

* updated CHANGELOG with relevant info

* updated ruby version in gemspec

* set the target ruby version in rubocop to 2.5

* removed the redudant begin since ruby 2.5

Author: rishijain

.github/workflows/main.yml

@@ -29,7 +29,6 @@ jobs:
       fail-fast: false
       matrix:
         ruby-version:
-          - '2.4'
           - '2.5'
           - '2.6'
           - '2.7'
@@ -63,7 +62,6 @@ jobs:
       fail-fast: false
       matrix:
         ruby-version:
-          - '2.4'
           - '2.5'
           - '2.6'
           - '2.7'
@@ -96,7 +94,6 @@ jobs:
       fail-fast: false
       matrix:
         ruby-version:
-          - '2.4'
           - '2.5'
           - '2.6'
           - '2.7'
@@ -129,7 +126,6 @@ jobs:
       fail-fast: false
       matrix:
         ruby-version:
-          - '2.4'
           - '2.5'
           - '2.6'
           - '2.7'

.rubocop.yml

@@ -5,7 +5,7 @@ AllCops:
     - 'tmp/**/*'
     - 'vendor/**/*'
     - 'gemfiles/*'
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
 
 Metrics/BlockLength:
   Enabled: false

CHANGELOG.md

@@ -1,5 +1,7 @@
 # main [(unreleased)](https://github.com/whitesmith/rubycritic/compare/v4.7.0...main)
 
+* [CHANGE] Drop support for Ruby 2.4.x (by [@rishijain][])
+
 # v4.7.0 / 2022-05-06 [(commits)](https://github.com/whitesmith/rubycritic/compare/v4.6.1...v4.7.0)
 
 * [CHANGE] Run test suite with Ruby 3.1 (by [@etagwerker][])

README.md

@@ -235,7 +235,6 @@ See [formatters](docs/formatters.md)
 
 RubyCritic is supporting Ruby versions:
 
-* 2.4
 * 2.5
 * 2.6
 * 2.7

rubycritic.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |spec|
   spec.summary       = 'RubyCritic is a Ruby code quality reporter'
   spec.homepage      = 'https://github.com/whitesmith/rubycritic'
   spec.license       = 'MIT'
-  spec.required_ruby_version = '>= 2.4.0'
+  spec.required_ruby_version = '>= 2.5.0'
 
   spec.files = [
     'CHANGELOG.md',

test/test_helper.rb

@@ -29,17 +29,15 @@ def capture_output_streams
 
 def with_cloned_fs
   FakeFS do
-    begin
-      FakeFS::FileSystem.clone(PathHelper.project_path)
+    FakeFS::FileSystem.clone(PathHelper.project_path)
 
-      # reek schema is required to init reek
-      FakeFS::FileSystem.clone(PathHelper.reek_schema_path)
+    # reek schema is required to init reek
+    FakeFS::FileSystem.clone(PathHelper.reek_schema_path)
 
-      Dir.chdir(PathHelper.project_path)
-      yield
-    ensure
-      FakeFS::FileSystem.clear
-    end
+    Dir.chdir(PathHelper.project_path)
+    yield
+  ensure
+    FakeFS::FileSystem.clear
   end
 end
 

travis_scripts/before_script.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
 set -ev
-if [ "${TRAVIS_RUBY_VERSION}" != "2.4" ] && [ "${TRAVIS_RUBY_VERSION}" != "3.0" ]; then
+if [ "${TRAVIS_RUBY_VERSION}" != "3.0" ]; then
   bundle exec appraisal install
 fi

travis_scripts/script.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 set -ev
 echo "Using Ruby v${TRAVIS_RUBY_VERSION}"
-if [ "${TRAVIS_RUBY_VERSION}" = "2.4" ] || [ "${TRAVIS_RUBY_VERSION}" = "3.0" ]; then
+if [ "${TRAVIS_RUBY_VERSION}" = "3.0" ]; then
   bundle exec rake test
 else
   bundle exec appraisal rake test
-fi
+fi