Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova 5 support #112

Open
VGirol opened this issue Dec 18, 2024 · 1 comment
Open

Nova 5 support #112

VGirol opened this issue Dec 18, 2024 · 1 comment

Comments

@VGirol
Copy link

VGirol commented Dec 18, 2024

Hi,

Thanks for your packages. Any chance to get this updated to support Nova 5.x released a few days ago?

Thanks

@MannikJ
Copy link

MannikJ commented Jan 24, 2025

I started migrating to v5 in my fork, but realized there are many changes required. It's not that easy to just make it work.

In the current state I can at least install the package and my pages are working as well. I can also include the Nova tool without any errors, but when actually loading it to edit resources there are many errors. The tests except one execute without errors, but apparently they only cover a fraction of what is really needed to use the package in an application, so that's not the best indicator.

Manager, Template, StaticResource, PageResource and the tests require major rewrites to make it work with the strict typing in Nova v5. Nova will not allow replacing actual classes with Mocks because of type incompatiblities for example.
For me at this point it is the current state of my fork is sufficient, because we rarely change the content of our pages and I could also do that manually in the json if really needed. Most of our templates haven't been working anyway for a while.

But would be great if we could make it fully work in Nova v5. Maybe we can join forces and see how to fix the issues together. I have the feeling whitecube will not put in a lot of time into this package anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants