From 76d44d098e4ea8f33d32cf59dd6c7f2fb9a2a43b Mon Sep 17 00:00:00 2001 From: trustme000777 Date: Wed, 22 May 2019 20:32:56 +0200 Subject: [PATCH] clarify consistency requirements of GetActionResult (#79) - move the statement from the service documentation to the call. - add a section about extending TTLs related discussions: - https://groups.google.com/d/msg/remote-execution-apis/zmcEV8kubRc/5PPcHOVZAgAJ - https://github.com/bazelbuild/bazel/issues/6862 --- .../bazel/remote/execution/v2/remote_execution.proto | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/build/bazel/remote/execution/v2/remote_execution.proto b/build/bazel/remote/execution/v2/remote_execution.proto index 5ba4ff6..3305aa3 100644 --- a/build/bazel/remote/execution/v2/remote_execution.proto +++ b/build/bazel/remote/execution/v2/remote_execution.proto @@ -128,10 +128,7 @@ service Execution { // // The lifetime of entries in the action cache is implementation-specific, but // the server SHOULD assume that more recently used entries are more likely to -// be used again. Additionally, action cache implementations SHOULD ensure that -// any blobs referenced in the -// [ContentAddressableStorage][build.bazel.remote.execution.v2.ContentAddressableStorage] -// are still valid when returning a result. +// be used again. // // As with other services in the Remote Execution API, any call may return an // error with a [RetryInfo][google.rpc.RetryInfo] error detail providing @@ -140,6 +137,13 @@ service Execution { service ActionCache { // Retrieve a cached execution result. // + // Implementations SHOULD ensure that any blobs referenced from the + // [ContentAddressableStorage][build.bazel.remote.execution.v2.ContentAddressableStorage] + // are available at the time of returning the + // [ActionResult][build.bazel.remote.execution.v2.ActionResult] and will be + // for some period of time afterwards. The TTLs of the referenced blobs SHOULD be increased + // if necessary and applicable. + // // Errors: // // * `NOT_FOUND`: The requested `ActionResult` is not in the cache.