Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Any leftover tokens in Airlock::migrate(...) is not transferred anywhere #325

Closed
clemlak opened this issue Jan 31, 2025 · 1 comment
Closed

Any leftover tokens in Airlock::migrate(...) is not transferred anywhere #325

clemlak opened this issue Jan 31, 2025 · 1 comment
Labels
🐛 bug Something isn't working 🦄 v3 Related to Uniswap V3 integration

Comments

@clemlak
Copy link
Collaborator

clemlak commented Jan 31, 2025

See https://cantina.xyz/code/57b00aab-8f8b-4d62-9378-41b6460ce6aa/findings/71
@clemlak clemlak added the 🐛 bug Something isn't working label Jan 31, 2025
This was referenced Jan 31, 2025
Closed
Merged
@saucepoint
Copy link
Contributor

The finding didnt allude to a reason for the bug, merely an observation.

Believed to be fixed in #331

See test where no assets are left in airlock, following a migration
https://github.com/whetstoneresearch/doppler/pull/331/files#diff-632c4b1e4ec0fefc67cb6b582efc8b8e4cd6a827d7a1170e33a61b171052f00aR106-R131

@aadams aadams added the 🦄 v3 Related to Uniswap V3 integration label Feb 4, 2025
@clemlak clemlak closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 🦄 v3 Related to Uniswap V3 integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aadams @clemlak @saucepoint