Safer use of slot0.currentTick #334
Open
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #317, #322
Safely retrieve "current tick" by converting it from the spot price
sqrtPriceX96As described in Cetora M02, and reference v4-core test
slot0.tickis decremented by one when zeroForOne trades push to a sqrtPriceLimit equal to a tick boundary of an LP position. This off-by-one error was problematic in Doppler when swapping to LOWER_SLUG.tickLower as well as some tick-delta calculations.Its an extreme edge case, but the fix is quite simple so did it anyway