Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow arbitrary bytes calldata for migrations #301

Open
saucepoint opened this issue Jan 27, 2025 · 2 comments
Open

Allow arbitrary bytes calldata for migrations #301

saucepoint opened this issue Jan 27, 2025 · 2 comments
Labels
✨ improvement Code optimization or better readability 🦄 v3 Related to Uniswap V3 integration

Comments

@saucepoint
Copy link
Contributor

Currently airlock.migrate(address asset) and ILiquidityMigrator.migrate(...) feels a little restrictive for "BYO migrator" functionality

I.e. to migrate to a v4 pool, asset creators may want to encode and configure a few different CLAMM positions. More so, other DEXes may require different parameters for liquidity provision
@clemlak
Copy link
Collaborator

clemlak commented Jan 27, 2025

Good point.

@aadams aadams added the 🦄 v3 Related to Uniswap V3 integration label Feb 4, 2025
@clemlak clemlak added the ✨ improvement Code optimization or better readability label Feb 5, 2025
@clemlak
Copy link
Collaborator

clemlak commented Feb 7, 2025

Main problem is that airlock.migrate(...) is permissionless, this means that we cannot really trust its inputs and this makes me uncomfortable to forward "random" bytes to ILiquidityMigrator.migrate(...).

@clemlak clemlak changed the title (improvement) Allow arbitrary bytes calldata for migrations Allow arbitrary bytes calldata for migrations Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ improvement Code optimization or better readability 🦄 v3 Related to Uniswap V3 integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aadams @clemlak @saucepoint