Take sizes from <img> if a <source> doesn't have a sizes attribute #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakearchibald
commented
May 19, 2021
| @@ -28722,9 +28723,15 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...</code | |||
| its value does not <span data-x="matches the environment">match the environment</span>, | |||
| continue to the next child.</p></li> | |||
|
|
|||
| <li><p><span data-x="parse a sizes attribute">Parse <var>child</var>'s sizes attribute</span> | |||
| with the fallback width <var>width</var>, and let <var>source set</var>'s <span>source | |||
There was a problem hiding this comment.
The "parse a sizes attribute" algorithm doesn't take a "fallback width" and there's no width variable in this algorithm. I assume this is left over from something?
zcorpan
reviewed
May 19, 2021
| <li><p>Let <var>sizesSource</var> be <var>el</var>.</p></li> | ||
|
|
||
| <li><p>If <var>child</var> <span data-x="concept-element-attribute-has">has</span> an | ||
| <span>attribute</span> whose <span>qualified name</span> is <code data-x="">"sizes"</code>, |
There was a problem hiding this comment.
I don't think you should check the qualified name; it would pick up a namespaced attribute with that name (can be set with setAttributeNS()). Also, link's sizes attribute is named imagesizes.
Say: If child has a sizes attribute present, ...
There was a problem hiding this comment.
Ah, good catch. I've changed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6633 by allowing sizes data to come from the
<img>if a particular sibling<source>doesn't have asizesattribute.(See WHATWG Working Mode: Changes for more details.)
/images.html ( diff )
/infrastructure.html ( diff )