Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider allowing negative source sizes in <img sizes>, clamping to 0 #3093

Open
zcorpan opened this issue Oct 4, 2017 · 1 comment
Open

Consider allowing negative source sizes in <img sizes>, clamping to 0 #3093

zcorpan opened this issue Oct 4, 2017 · 1 comment
Labels
topic: img

Comments

@zcorpan
Copy link
Member

zcorpan commented Oct 4, 2017

From #3084 (comment)

However, a mathematical function could evaluate differently each time sizes is parsed, and indeed it's possible it could be negative some of the time (e.g. for calc(500px - 50vw)). I don't remember why we made it invalid (and skipped over in parsing), rather than clamping to 0. The latter seems like it's less surprising behavior, so I'm open to changing that, [...]

cc @tabatkins @yoavweiss
@tabatkins
Copy link
Contributor

Yeah, I don't recall why I thought skipping was appropriate. Clamping to 0 is better.

@annevk annevk mentioned this issue Apr 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: img
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @tabatkins