Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorEvent.filename should include the hash of the URL #2074

Closed
zcorpan opened this issue Nov 22, 2016 · 3 comments
Closed

ErrorEvent.filename should include the hash of the URL #2074

zcorpan opened this issue Nov 22, 2016 · 3 comments
Labels
topic: error reporting

Comments

@zcorpan
Copy link
Member

zcorpan commented Nov 22, 2016

See web-platform-tests/wpt#4221

I suppose we should serialize the script URL including the hash.
@annevk
Copy link
Member

annevk commented Nov 22, 2016

Just serializing it should do the trick. Excluding the fragment is a flag.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 22, 2016

"the resource from which script was obtained" is not something that is already stored on script or its environment settings object, is it?

@annevk
Copy link
Member

annevk commented Nov 22, 2016

See #958. It's a mess.

zcorpan added a commit that referenced this issue Nov 22, 2016
@zcorpan
Invoke the URL serializer for ErrorEvent.filename
2ca723c 
The URL's hash should be included to match majority of browser
engines (WebKit, Gecko, Edge). An "absolute URL" is without the
hash according to the URL standard, but serializing a URL record
includes it by default.

Fixes #2074.
@zcorpan zcorpan mentioned this issue Nov 22, 2016
Merged
zcorpan added a commit that referenced this issue Nov 22, 2016
@zcorpan
Invoke the URL serializer for ErrorEvent.filename
2c8eef6 
The URL's hash should be included to match majority of browser
engines (WebKit, Gecko, Edge). An "absolute URL" is without the
hash according to the URL standard, but serializing a URL record
includes it by default.

Fixes #2074.
Closes web-platform-tests/wpt#4221.
alice pushed a commit to alice/html that referenced this issue Jan 8, 2019
@zcorpan
Invoke the URL serializer for ErrorEvent.filename
778d46d 
The URL's hash should be included to match majority of browser
engines (WebKit, Gecko, Edge). An "absolute URL" is without the
hash according to the URL standard, but serializing a URL record
includes it by default.

Fixes whatwg#2074.
Closes web-platform-tests/wpt#4221.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: error reporting
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zcorpan @domenic @annevk