Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leg_detector kinetic rtree issue #44

Closed
hvpandya opened this issue Aug 5, 2016 · 9 comments
Closed

leg_detector kinetic rtree issue #44

hvpandya opened this issue Aug 5, 2016 · 9 comments
Labels

Comments

@hvpandya
Copy link

hvpandya commented Aug 5, 2016

I observed @DLu started porting leg_detector to kinetic by changing CvRTrees to cv::ml::RTrees.

The new OpenCV 3.0 RTrees class does not have direct replacement members for load(), predict_prob() and get_active_var_mask() which are used in leg_detector.

I am unaware of the efforts going on to put those functions in OpenCV 3 or the efforts on modifying leg_detector to work with CV3 as is.

@DLu are you currently pursuing this actively or know about an effort in this direction? I might be able to contribute in my spare time, but I would rather not dive into it if someone is close to solving this issue.

Thanks,
Harsh

@DLu
Copy link
Member

DLu commented Aug 6, 2016

Hi Harsh.
I would greatly welcome your time with this. I was trying to get the code to compile in kinetic, and got as far as figuring out the new class name for CvRTrees. After that, I realized it was going to be a bit more work than I had time for.

@kdhansen
Copy link
Contributor

I have it compiling now. I need to check the detector when I get back to the lab Monday. I will send a pull request if it checks out.

@kdhansen
Copy link
Contributor

kdhansen commented Oct 1, 2016

So it works on my end on a Turtlebot 2. But as you can see in the pull request #48 Travis cannot test Kinetic code. So if someone could check that it also works for them, that would be great.

@DLu
Copy link
Member

DLu commented Oct 6, 2016

I am unclear what's going wrong with Travis here. Perhaps post it on answers.ros.org?

@kdhansen
Copy link
Contributor

kdhansen commented Oct 8, 2016

As I understand it, the Travis service only supports Precise and Trusty, neither is supported for Kinetic. However it seems @130s has a fix in #49 by running a Docker container.

@hvpandya
Copy link
Author

@kdhansen any movement on this?

@kdhansen
Copy link
Contributor

@hvpandya None, I have not had time to look at it. And it seems @130s also has trouble making the Travis Xenial/Kinetic run. That being said, the code runs fine on my Xenial/Kinetic installation, if you just need it to run.

@130s
Copy link
Contributor

130s commented Feb 18, 2017

See #48 (comment) for the progress with Travis CI.

@DLu
Copy link
Member

DLu commented Aug 28, 2018

Closed via #53

@DLu DLu closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants