Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit mailto links should match dots before the @-sign #5080

Open
david-pikas opened this issue Feb 26, 2024 · 0 comments · May be fixed by #6229
Open

Implicit mailto links should match dots before the @-sign #5080

david-pikas opened this issue Feb 26, 2024 · 0 comments · May be fixed by #6229
Labels
enhancement New feature or request PR-welcome Wez doesn't have plans to work on this, but will accept a PR if someone feels motivated!

Comments

@david-pikas
Copy link

david-pikas commented Feb 26, 2024

Is your feature request related to a problem? Please describe.

At my $DAYJOB we have [email protected] as email addresses. The default regex for finding mail links don't include dots before the @ sign, so only the [email protected] part gets included in the link.

Describe the solution you'd like

Change the default regexes to include dots before the at sign. Perhaps

\b\w+(\.\w+)*@[\w-]+(\.[\w-]+)+\b

Describe alternatives you've considered

I can of course change this myself in my local config but I figure that it would be good to change the default option as well.

Regexes are an insufficient tool to correctly parse all possible email addresses but this is a pretty common format for email addresses and it would make sense to have them included.

Looking at the regex, perhaps hyphens before the dot could be included as well?

@david-pikas david-pikas added the enhancement New feature or request label Feb 26, 2024
@wez wez added the PR-welcome Wez doesn't have plans to work on this, but will accept a PR if someone feels motivated! label Jul 13, 2024
lilHermit added a commit to lilHermit/wezterm that referenced this issue Oct 4, 2024
lilHermit added a commit to lilHermit/wezterm that referenced this issue Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR-welcome Wez doesn't have plans to work on this, but will accept a PR if someone feels motivated!
Projects
None yet
2 participants