Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select specific host when running debug command #56

Open
4 tasks
lthibault opened this issue Nov 14, 2022 · 0 comments
Open
4 tasks

Select specific host when running debug command #56

lthibault opened this issue Nov 14, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lthibault
Copy link
Collaborator

lthibault commented Nov 14, 2022

Currently, ww debug's subcommands target an arbitrary host, the one that with which the client happens to be connected. The debug commands take a <peer> argument, intended to be either an instance ID or a libp2p peer.ID. This should be used to designate the node being debugged.

The preferred way to achieve this is through the Anchor API, which still needs to be re-implemented after the major overhaul of the cluster.Host capability. As before, we want to define a Go interface for Anchor so that we can present a type-switch based API for interacting with various anchor types (cluster, host, in-host path...). Asking users to recast capability clients is bound to confuse them.

Note that only a partial implementation of anchor is needed, as only root and host anchors are required.

Marking this as a bug since the current CLI's behavior is covert, and basically just wrong.

Tasks

Most of these are subtasks of #57.

  • Define Go interface for Anchor
  • Implement Anchor API methods in client.Node
  • Implement anchor.Host; ensure it provides access to a Host capability
  • Call Walk from ww debug, type-assert for anchor.Host, and obtain debugger
@lthibault lthibault added the bug Something isn't working label Nov 14, 2022
@lthibault lthibault added this to the 0.1.0 Public Beta Release milestone Nov 14, 2022
@lthibault lthibault self-assigned this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant