Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication for client capabilities. #16

Closed
2 tasks
lthibault opened this issue Apr 21, 2022 · 2 comments
Closed
2 tasks

Add authentication for client capabilities. #16

lthibault opened this issue Apr 21, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request security Has security implications
Milestone

Comments

@lthibault
Copy link
Collaborator

This is a two-part task:

  • Design capability authentication protocol
  • Consider collapsing per-capability protocol.IDs into a single endpoint.

Capability Authentication

// TODO ...

protocol.ID and RPC Considerations

Splitting capabilities into their own protocol.ID endpoints is expected to have a measurable impact on performance. However, this warrants an investigation into security implications.

Pro

  • Per-object flow-control
  • Per-object transport streams can improve performance (esp. w/ QUIC)
  • Modularity at the libp2p level

Con

  • Requires per-capability authentication
    • Increases size of ambient-auth <--> capability boundary
    • But perhaps we can mitigate this by reusing exactly the same auth code for each stream?
@lthibault
Copy link
Collaborator Author

https://github.com/wetware/ww/issues/40#issuecomment-1185737085 argues against per-capability protocol handlers.

@lthibault
Copy link
Collaborator Author

Implemented in v0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security Has security implications
Projects
None yet
Development

No branches or pull requests

1 participant