Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too strong config validation for clustering option #290

Open
zachary-povey opened this issue Jul 20, 2020 · 0 comments
Open

Too strong config validation for clustering option #290

zachary-povey opened this issue Jul 20, 2020 · 0 comments

Comments

@zachary-povey
Copy link

I may have misunderstood, but in com.wepay.kafka.connect.bigquery.config.BigQuerySinkTaskConfig line 243 it seems that we are asserting that if timestampPartitionFieldName isn't set and bigQueryPartitionDecorator is set to false then the resulting table won't be partitioned (and thus we cannot cluster).

I don't believe this is the case, we will still be partitioned using the _PARTITIONTIME pseudo-column, however the messages will be assigned a partition by BigQuery based on when the message was received there - right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant