Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure users can't complete sign up if they don't accept the T&Cs #339

Open
alexwlchan opened this issue Jun 23, 2022 · 1 comment
Open

Comments

@alexwlchan
Copy link
Contributor

There's a TODO comment here that suggests we might not be doing that:

// TODO: It would be good to improve this further by checking for app_metadata.terms_and_conditions_accepted here

I want to double check it and update that TODO.

@alexwlchan
Copy link
Contributor Author

Testing this, it looks like we have client-side validation that you can't submit the form. I want to double-check that's validated on the server-side (and maybe recorded in Sierra?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant