Do not panic on duplicate declarations in decl-index #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschrempf
force-pushed
the
dom/1155/duplicate-declarations
branch
17 times, most recently
from
aaae483 to
1737ffc
Compare
Instead, we remove duplicate declarations from the `DeclIndex`, and issue respective warnings. Also, during selection, when a declaration is unavailable because it depends on an unavailable transitive dependency, we report the `SingleLoc` of the unavailable transitive dependency. This greatly eases finding the correct parse and select predicates.
dschrempf
force-pushed
the
dom/1155/duplicate-declarations
branch
from
1737ffc to
8fb0c48
Compare
dschrempf
force-pushed
the
dom/1155/duplicate-declarations
branch
3 times, most recently
from
e8a4327 to
0de2f2a
Compare
Paired session with Edsko
dschrempf
force-pushed
the
dom/1155/duplicate-declarations
branch
from
0de2f2a to
517e1b0
Compare
edsko
approved these changes
Dec 2, 2025
Collaborator
edsko
left a comment
edsko
left a comment
There was a problem hiding this comment.
Great, will be good to finally get this in after all the hard thinking :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we remove duplicate declarations from the
DeclIndex, and issue respective warnings.Also, during selection, when a declaration is unavailable because it depends on an unavailable transitive dependency, we report the
SingleLocof the unavailable transitive dependency. This greatly eases finding the correct parse and select predicates.TODO:
SharedKeytrace (probably even use the same trace message type).TODO AFTER MERGE:
--parse-allrequired).