-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to users to choose language during config #69
Comments
Options to add: Multiple languages or Single language limit only? |
@Siddhant-K-code if you could draw up a figma with a good design for multiple languages we might be able to implement that |
@akshgpt7 was thinking about tackling it. Please share your proposal here so we can discuss and be in alignment before you are too far into it~ |
@wei I went through the code and realized I need to read up a bit more about GraphQL to get myself up to speed. |
@akshgpt7 The only graphql you need to change is this, you will get an array of 10 languages, and it is about designing a UI element to switch languages. languages(orderBy: {field: SIZE, direction: DESC}, first: 10) { Change the file here: socialify/common/relay/repoQuery.ts Lines 14 to 20 in b71d5dd
You can mess with graphql directly here: https://developer.github.com/v4/explorer/ |
We also need to check the language returned against the list of languages we have devicons for and hide the ones that are not supported. We should use devicons naming in the url query string and in the dropdown so we can do
too. |
Now that we are using simple-icons, it is very easy to add new languages. We can start with the most popular languages by github/linguist and add in some popular frameworks like React, Svelte, etc in https://survey.stackoverflow.co/2022 |
Enables users to choose from all the languages on their repo to highlight whichever language they want.
Enables custom language choices to display logos like react also
From reddit
The text was updated successfully, but these errors were encountered: