Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename chatie-grpc -> wechaty-grpc #163

Closed
huan opened this issue Feb 16, 2021 · 4 comments
Closed

Rename chatie-grpc -> wechaty-grpc #163

huan opened this issue Feb 16, 2021 · 4 comments
Labels
🔥 enhancement New feature or request

Comments

@huan
Copy link
Member

huan commented Feb 16, 2021

After some time, we believe that the gRPC package is a Wechaty ecosystem module, so it will be better named wechaty-grpc.

The NPM module will be renamed soon: wechaty/grpc#106

I'd like to suggest that the Python Wechaty follow this naming conversion, use a new module named wechaty-grpc in the future as well.

@huan huan added the 🔥 enhancement New feature or request label Feb 16, 2021
@huan
Copy link
Member Author

huan commented Feb 22, 2021

Link to wechaty/grpc#117

Please help to approve the PR so that we can have enough confidence to merge it.

Thanks!

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Feb 22, 2021

Approvement given. 🌸

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Mar 5, 2021

You made a great breaking change for python-wechaty, thanks a lot. I'll close this issue.

@wj-Mcat wj-Mcat closed this as completed Mar 5, 2021
@huan
Copy link
Member Author

huan commented Mar 5, 2021

Thanks for closing this issue.

However, I do not think we have any breaking changes for the public API in this PR, everything should keep unchanged from our users!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants