Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel safety/Idle tokio tasks after WebRTC session close #600

Open
alexipeck opened this issue Aug 12, 2024 · 0 comments
Open

Cancel safety/Idle tokio tasks after WebRTC session close #600

alexipeck opened this issue Aug 12, 2024 · 0 comments

Comments

@alexipeck
Copy link
Contributor

I have been trying to diagnose issues within my own project related to WebRTC and after using tokio-console, I started noticing many idle tokio tasks spawned by this library which don't get closed after the WebRTC session should have closed. I have observed 23-24 tasks which stay idle, but the screenshot below shows 18.

I am under the assumption that part may be attributable to missing cancel safety?
Note that this screenshot is after running .close() on the peer connection
image

I started this issue to form a discussion on what's needed within the project to improve cancel safety

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant