Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Merge workflow job types #2068

Draft
wants to merge 24 commits into
base: main
Choose a base branch
from
Draft

feat: Merge workflow job types #2068

wants to merge 24 commits into from

Conversation

SuaYoo
Copy link
Collaborator

@SuaYoo SuaYoo commented Sep 9, 2024 •
edited
Loading

Resolves #2073

Changes

  • Removes "URL List" and "Seeded Crawl" job type distinction and adds as additional crawl scope types instead.
  • Enables specifying DOCS_URL in .env

Manual testing

  1. Log in as crawler
  2. Create new workflow with each crawl scope type. Verify workflow saves and crawls as expected
  3. Repeat with edit and duplicate

Screenshots

Page Image/video
Crawl Workflows Screenshot 2024-09-16 at 12 34 19 PM

@SuaYoo SuaYoo force-pushed the frontend-new-workflow-terms--merge-job-types branch from 6046e95 to fccb9d5 Compare September 10, 2024 01:17
@SuaYoo SuaYoo force-pushed the frontend-new-workflow-terms--merge-job-types branch from fccb9d5 to e166923 Compare September 10, 2024 23:41
@SuaYoo

This comment was marked as resolved.

Sign in to view
@Shrinks99

This comment was marked as resolved.

Sign in to view
@SuaYoo SuaYoo marked this pull request as ready for review September 16, 2024 19:36
@SuaYoo SuaYoo requested a review from tw4l September 16, 2024 19:36
SuaYoo and others added 3 commits September 16, 2024 12:40
@SuaYoo
hide scope type from url
da067d6
@emma-sg
Merge branch 'main' into frontend-new-workflow-terms--merge-job-types
47d878e
@emma-sg
remove min-height on panel content
6ecfa55 
it was causing unwanted layout changes when checking "include any linked page" when the crawl scope is "single page"
emma-sg
emma-sg requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm seeing some odd behaviour with the router though, using the browser's back button from the new crawl workflow page doesn't seem to work?

Screen.Recording.2024-09-16.at.5.08.18.PM.mov

Shrinks99
Shrinks99 reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing an existing crawl with a scope of "Single page" gives a workflow editor with the Page URL left blank.

@SuaYoo SuaYoo marked this pull request as draft September 18, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shrinks99 Shrinks99 Shrinks99 left review comments

@emma-sg emma-sg emma-sg requested changes

@ikreymer ikreymer Awaiting requested review from ikreymer

@DaleLore DaleLore Awaiting requested review from DaleLore

@tw4l tw4l Awaiting requested review from tw4l

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Merge workflow job types into additional scope types
3 participants
@SuaYoo @Shrinks99 @emma-sg