Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Auto-loading replay with single seed URLs that use basic auth doesn't work #1952

Open
Shrinks99 opened this issue Jul 22, 2024 · 0 comments
Labels
bug Something isn't working front end Requires front end dev work

Comments

@Shrinks99
Copy link
Member

Shrinks99 commented Jul 22, 2024

Browsertrix Version

v1.10.2-dc9069d

What did you expect to happen? What happened instead?

As of 06b512b, the frontend will automagically give ReplayWeb.page the seed URL as a starting URL if there is only one seed URL in the crawl workflow. This is mostly good and gets users to where they want to go faster, but in the case of basic auth, we strip the credentials before writing the URLs which means that the page http://username:[email protected] isn't present in the archive (and should instead just return http://example.com as the url for ReplayWeb.page to load).

Reproduction instructions

  1. Crawl a webpage with basic auth.
  2. Once the crawl is finished, load the replay tab, note that it should not load properly.
  3. Strip the credentials from the URL and attempt to load that page from the archive, note that it should load properly.

Additional details

Originally reported by @edsu, thanks!

@Shrinks99 Shrinks99 added bug Something isn't working front end Requires front end dev work labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end Requires front end dev work
Projects
Status: Triage
Development

No branches or pull requests

1 participant