Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output.clean : true is not working with dev server #861

Open
webpack-bot opened this issue Mar 22, 2021 · 21 comments
Open

output.clean : true is not working with dev server #861

webpack-bot opened this issue Mar 22, 2021 · 21 comments

Comments

@webpack-bot
Copy link

Bug report

What is the current behavior?

output.clean: true is not working with webpack dev server, when building for the first time, or when project is rebuilding due to sources change.

Description

I was trying to configure webpack to clean the dis folder for one of my projects, and decided to use brand new output.clean configuration as I'm using "webpack": "^5.21.2" and this config is supported starting from version 5.20

Config works fine in production build, but when I start webpack dev server with writeToDisk: true webpack doesn't clean the dist/ directory neither upon the start of the dev server nor upon project rebuild.

Initially I though that it might be not supposed to work with dev server, but changing

output: {
    ...
    clean: true
  },

to

output: {
    ...
    clean: {
      dry: true,
    }
  },

does log what files it should delete when rebuilding project:

image

If the current behavior is a bug, please provide the steps to reproduce.

  1. clone my sandbox created for debugging this issue https://github.com/vovkvlad/webpack_clean-test
  2. run npm i in the root of the repository
  3. run npm start to start the application
  4. go to src/App.js and make any change so that webpack catch it up and rebuild the project

Expected behavior:

old files from dist/ folder should me removed, and dist/ folder should contain one instance of each bundled file

Current behavior:

dist/ folder is not being cleaned, and contains several files for each bundled files:

image

What is the expected behavior?
old files from dist/ folder should me removed, and dist/ folder should contain one instance of each bundled file

Other relevant information:
webpack version: webpack 5.27.1
Node.js version: v14.15.0
Operating System: macOs Catalina Version 10.15.7
Additional tools:


This issue was moved from webpack/webpack#12949 by @alexander-akait. Original issue was by @vovkvlad.

@alexander-akait
Copy link
Member

I have ideas how we can fix it, but need more time, idea:

compiler.outputFileSystem = new CombinedFileSystem(memoryFileSystem, realFileSystem)

so we will have layer layered file system (memory + real fs)

@daniele-orlando
Copy link

I can reproduce the problem with Webpack 5.36.

    output: {
        clean: true,
    },
    devServer: {
        writeToDisk: true,
    },

@mateusz-owczarek
Copy link

I can reproduce that too with webpack 5.36.2 and webpack-dev-server 3.11.2 and the configuration:

output: {
    clean: true,
},
devServer: {
    writeToDisk: true,
}

@aetherplex
Copy link

Any updates on this? Still an issue with webpack 5.51.1 and webpack-dev-middleware 5.0.0.

@alexander-akait
Copy link
Member

No, it will be fixed in near future, we need layer fs

@josudoey
Copy link

josudoey commented Nov 13, 2021

the output.clean release at webpack v5.20.0 and the issue already exists.

@ahmafi
Copy link

ahmafi commented Dec 25, 2021

Same problem on webpack 5.65.0 and webpack-dev-server 4.6.0

@PanKarton
Copy link

Yoooo, still nothing? xD

@rudyhuynh
Copy link

I just keep using clean-webpack-plugin then.

@chavlji
Copy link

chavlji commented Feb 24, 2022

:(

@dgpt
Copy link

dgpt commented Apr 6, 2022

Still a bug as of webpack 5.71.0 and webpack-dev-server 4.7.4

@VinnyFonseca
Copy link

VinnyFonseca commented May 11, 2022

No, it will be fixed in near future, we need layer fs

9 months later and still nothing. Is this "near future"?

Still happening with webpack 5.72.0 and webpack-dev-server 4.9.0.

@jcreek
Copy link

jcreek commented Oct 7, 2022

Still happening for me with webpack 5.73.0 and webpack-dev-server 4.9.2.

@BigFax
Copy link

BigFax commented Oct 26, 2022

Hello :)
Just to let you know that I have the same issue with clean: true, but with webpack-hot-middleware which doesn't use webpack-dev-server but only webpack-dev-middleware.

When I use webpack from cli, it works.
When I use the process as a middleware, it works for my asset/resource type in module, but it doesn't for the js files from the output configuration, these files are generated again each time without deletion.

Clean Webpack Plugin works fine from cli & from middleware.

webpack : 5.74.0
webpack-dev-middleware : 5.3.3
webpack-hot-middleware : 2.25.0

@puranjayjain
Copy link

Still happens with me as well

@brycekunkel
Copy link

brycekunkel commented Nov 10, 2022

Interesting note, I've been using Clean Webpack Plugin while waiting for a solution here, but noticed that after initial bundling, an asset is still available on the localhost even though it's not shown in the file tree. I can still access that asset directly by visiting the link to it in the browser. This was resolved when I set the output.clean: true in my webpack config.

@AaronMcCloskey
Copy link

Still an issue with webpack 5.74.0 and webpack-dev-server 4.11.1.

Clean Webpack Plugin isn't working for me either.

I'm not sure if it's because my path is not a static path, as it is based on a version number from the previous git commit, so I have multiple build/app/:version folders that never get cleared? So the more commits I make the more folders I have.

const VERSION = childProcess.execSync('git rev-parse --short HEAD').toString().trim();
const ASSET_PATH = `/app/${VERSION}/`;

return {
  ...
  plugins: [
    new CleanWebpackPlugin(),
  ],
  output: {
      publicPath: ASSET_PATH,
      filename: '[name].[fullhash].js',
      chunkFilename: '[name].[hash].[chunkhash].chunk.js',
      path: path.resolve(__dirname, `build/${ASSET_PATH}`),
      clean: true,
    },
};

@alexander-akait
Copy link
Member

alexander-akait commented May 2, 2023

Sorry for delay, I am looking for a solution before the next webpack-dev-server release (with the latest version of webpack-dev-server)

@AaronMcCloskey It doesn't work because you use path: path.resolve(__dirname, build/${ASSET_PATH}), i.e. CleanWebpackPlugin and webpack's output.clean try to remove files inside path.resolve(__dirname, build/${ASSET_PATH}).

Based on your configuration it is expected, so you allow to download old version of your application, anyway if you want to make it work you need to specify filename: ${ASSET_PATH}/[name].[fullhash].js (same for chunkFilename/assetsFilename and other *filename options) and path: path.resolve(__dirname, "build"), so the root of your assets will be the build directory and everything inside will be cleaned, but your problem is not related to report

@alexander-akait
Copy link
Member

Fixed: when you have writeToDisk: true, still have some limitations:

  1. If you don't have writeToDisk option and still see the dist directory it's because we try to avoid extra removing due erf reasosns, because it is development enviroments
  2. If you have writeToDisk: (pathToFile) => /regexp/.test(pathToFile) still buggy

@olosegres
Copy link

olosegres commented Jan 30, 2024

@alexander-akait
Bug still preset in [email protected] when it runs via webpack serve and when we have both output.clean: true and writeToDisk: true

@alexander-akait
Copy link
Member

@olosegres Please provide reproducible test repo, writeToDisk: true was fixed a long time ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests