Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing Concern with a Dependency Used by imagemin-pngquant #418

Closed
1 of 4 tasks
kmalyshev opened this issue Oct 10, 2023 · 4 comments
Closed
1 of 4 tasks

Licensing Concern with a Dependency Used by imagemin-pngquant #418

kmalyshev opened this issue Oct 10, 2023 · 4 comments

Comments

@kmalyshev
Copy link

Documentation Is:

  • Missing
  • Needed
  • Confusing
  • Not Sure?

Please Explain in Detail...

Your Proposal for Changes

imagemin-pngquant is licensed under the MIT License, but it seems to use a dependency that is under the GPL license, which might impose GPL’s licensing requirements on users of imagemin-pngquant and eventually image-minimizer-webpack-plugin.

imagemin/imagemin-pngquant#77

Is it possible to drop this dependency?

@alexander-akait
Copy link
Member

We don't install imagemin-pngquant by default, because we support a lot of different tools, if you don't want to use it just don't use it, look at our package file https://github.com/webpack-contrib/image-minimizer-webpack-plugin/blob/master/package.json#L71, alternatively you can use sharp for example instead imagemin, feel free to feedback

@evenstensberg
Copy link
Member

@alexander-akait we should maybe have a note in a readme somewhere about 3rd party licensing?

@alexander-akait
Copy link
Member

@evenstensberg We can, but tracking all vendors licenses can be a problem, I think developers must check vendor's licenses or they can setup this job on CI for it

@evenstensberg
Copy link
Member

ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants