Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Closure exits with non-zero code but no stderr, output is not minified and there are no errors #162

Open
ian-craig opened this issue Mar 26, 2021 · 0 comments · May be fixed by #163
Open

When Closure exits with non-zero code but no stderr, output is not minified and there are no errors #162

ian-craig opened this issue Mar 26, 2021 · 0 comments · May be fixed by #163

Comments

@ian-craig
Copy link
Contributor

I hit this when the plugin decided to use 'native' Closure but vcredist was missing on a build agent. The .exe was returning a non-zero exit code but no stderr output, and the result was that Webpack reported success but the JS was not minified.

It looks like the compilerProcess error handling logic in the plugin just misses this edge case.

I'll submit a PR shortly.
@ian-craig ian-craig linked a pull request Mar 26, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure error is logged when Closure fails ian-craig/closure-webpack-plugin
1 participant
@ian-craig