Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command browser.executeWorkbench doesn't allow to pass in more params #34

Open
christian-bromann opened this issue Aug 25, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@christian-bromann
Copy link
Contributor

The executeWorkbench does not allow to have additional parameters, I'ld suggest to change it to the following:

executeWorkbench: <T>(fn: (vscode: any, ...params: any[]) => T) => Promise<T>;
executeWorkbench: <T>(fn: (vscode: any, ...params: any[]) => T, ...params: any[]) => Promise<T>;

Additional points if the types added to the command are propagated to the callback function.

@christian-bromann christian-bromann added the help wanted Extra attention is needed label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant