Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SettingsEditor functions don't appear to be working properly #127

Open
petehale opened this issue Jul 10, 2024 · 2 comments
Open

SettingsEditor functions don't appear to be working properly #127

petehale opened this issue Jul 10, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@petehale
Copy link

I am trying to use the SettingsEditor returned from workbench.openSettings(), but subsequent function calls on the settings editor instance don't appear to be run against the open setting page.

This is the code I am using

  const settings: SettingsEditor = await workbench.openSettings();
  await settings.switchToPerspective('Workspace');
  const tab = await settings.getTab();
  await tab.select();

The call to switchToPerspective is failing with Can't call click on element with selector ".//a[@title='Workspace']" because element wasn't found.

I am also using the function await editor.findSetting(myTitle, myCategory); Observing the workspace, with settings open as well as Enabled Extensions, I can see the text for then find written into the search input area for EnabledExtensions.

Am I using the interfaces correctly?

@petehale petehale changed the title SettingEditor function don't appear to be working properly SettingsEditor functions don't appear to be working properly Jul 10, 2024
@peternhale
Copy link

I think the selector being used in switchToPerspective is incorrect. With settings open, searching for .//a[@title='Workspace'] yields 0 while .//a[text()='Workspace'] yields 1.

@christian-bromann
Copy link
Contributor

@petehale mind raising a PR for this?

@christian-bromann christian-bromann added the help wanted Extra attention is needed label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants