Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use builtin scrypt from node >= 12.8 #3

Open
sidhujag opened this issue Dec 20, 2019 · 1 comment
Open

use builtin scrypt from node >= 12.8 #3

sidhujag opened this issue Dec 20, 2019 · 1 comment

Comments

@sidhujag
Copy link

sidhujag commented Dec 20, 2019

https://github.com/web3-js/scrypt-shim/blob/master/src/index.js#L38
checks for fallback which I believe the maxmem was fixed to improve addressing from 32 to 53 bits. Can we enable this as of node 12.8 to remove scrypt as a dependency totally? Currently it still tries to find scrypt package if using node >= 12, but as of 12.8 we can depend on the built-in one. This ensures that no scrypt package is required.

See nodejs/node#28755
and release:
https://nodejs.org/ru/blog/release/v12.8.0/

@michaelsbradleyjr
Copy link
Collaborator

See: web3/web3.js#3284 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants