Add Proxy test to test/testSendNotification.js

[marco-c]

Follow-up to #319.

[vipulchhabra99]

hello @marco-c is this issue still open?

[marco-c]

Yes.

[vipulchhabra99]

ok @marco-c then what needs to be done in this bug?

[marco-c]

#319 (comment)

[sudipt1999]

Can I work on this!

[marco-c]

Yes. Anyone can work on any open issue which is not assigned and which has no PR open linked to it.

[amrrsharaff]

Hi, is there anymore documentation on this other than the comment referred to above? I am new to the community and I would like to work on this but I can't really see any description of what exactly should be done.

[marco-c]

@amrrsharaff the issue is pretty self explanatory: a test for the "proxy" option, option which was implemented in #319, needs to be added in test/testSendNotification.js.

[acou06281213]

サンキュー

[StarWonder67]

Hi,i am working on this issue.

[StarWonder67]

@marco-c I am new to FOSS. I have forked this repo and created a PR on my local repository. Should I create a PR to the original repository? Will be obliged if you could review it once.

[marco-c]

@StarWonder67 yes, you should create a PR on this repo.

[StarWonder67]

@marco-c I have tried numerous methods but I can't seem to create a PR to this repo. The authentication is failing. Although I have created a PR on my local repo.
Here's the link: https://github.com/StarWonder67/web-push/pulls

[marco-c]

The PR on your repo can't be used to merge code on this repo, you will have to create a PR on this repo.
You don't need to authenticate other than logging-in on GitHub. You can create a PR on this repo from https://github.com/web-push-libs/web-push/compare.