Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch config file and auto restart on change #3463

Closed
lsdsjy opened this issue Jun 7, 2023 · 4 comments
Closed

Watch config file and auto restart on change #3463

lsdsjy opened this issue Jun 7, 2023 · 4 comments
Labels
feat New feature or request same as webpack The behavior is the same as Webpack

Comments

@lsdsjy
Copy link
Contributor

lsdsjy commented Jun 7, 2023

What problem does this feature solve?

When using rspack serve, changes to config file can automatically trigger a restart of dev server (like vite dev).

What does the proposed API of configuration look like?

N/A

@lsdsjy lsdsjy added feat New feature or request pending triage The issue/PR is currently untouched. labels Jun 7, 2023
@hardfist
Copy link
Contributor

hardfist commented Jun 7, 2023

related to webpack/webpack-cli#15
there're some blockers on webpack side webpack/webpack-cli#15 (comment)
@alexander-akait any plan for webpack/webpack-cli#15 ?

@alexander-akait
Copy link

@hardfist

Yes, this is still in the plans, but unfortunately it's a bit difficult to implement it correctly, vite just restarts everything and not invalidate the dependency graph (for example if you have multi compiler mode and change only one configuration file, you don't need to rebuild all compilations), it's not quite right, but most likely enough for the needs of most. The question is - do we want the correct implementation or just implement this and say we support it, to be honest, the configurations don't change often, so it wasn't a priority

@hyf0 hyf0 added awaiting more feedback and removed pending triage The issue/PR is currently untouched. labels Jun 9, 2023
@th3fallen
Copy link

On the topic it would be amazing if we could provide a list of files to the watch config and cause a restart of the dev server if they change like .env files for example

@xc2 xc2 added same as webpack The behavior is the same as Webpack and removed awaiting more feedback labels May 10, 2024
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jun 25, 2024

The behavior is the same with webpack.

@h-a-n-a h-a-n-a closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request same as webpack The behavior is the same as Webpack
Projects
None yet
Development

No branches or pull requests

7 participants