Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: npx create-rslib --template is broken #426

Open
chenjiahan opened this issue Nov 15, 2024 · 2 comments
Open

[Bug]: npx create-rslib --template is broken #426

chenjiahan opened this issue Nov 15, 2024 · 2 comments
Assignees
Labels
🐞 bug Something isn't working

Comments

@chenjiahan
Copy link
Member

Version

Rslib 0.0.18

Details

This is expected to work:

npx create-rslib --template react-js --dir my-lib

Image

Ref:

Reproduce link

/

Reproduce Steps

/

@chenjiahan chenjiahan added the 🐞 bug Something isn't working label Nov 15, 2024
@fi3ework
Copy link
Member

The template is now generated with optional tools, and the name should be changed to pnpm create rslib --template "[react]-[]-js" --dir my-lib2.

Yes, the name is ugly. We might, should support an extra argv for tools, for example pnpm create rslib --template react-js --tool vitest --tool storybook. What do you think?

@chenjiahan
Copy link
Member Author

Agreed, the template name should be clean and intuitive and a new tool flag is also helpful.

@fi3ework fi3ework self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants