Skip to content

Commit 306f587

Browse files
committed
feat(doc): Documentation update
WE2-587 Signed-off-by: Mati Agukas <[email protected]>
1 parent fbb1555 commit 306f587

File tree

10 files changed

+180
-181
lines changed

10 files changed

+180
-181
lines changed

.github/workflows/dotnet-build-linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
- name: Setup dotnet
1313
uses: actions/setup-dotnet@v1
1414
with:
15-
dotnet-version: 5.0.x # SDK Version to use.
15+
dotnet-version: 6.0.x # SDK Version to use.
1616

1717
- name: Cache Nuget packages
1818
uses: actions/cache@v2

.github/workflows/dotnet-build-windows.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ jobs:
1212
- name: Setup dotnet
1313
uses: actions/setup-dotnet@v1
1414
with:
15-
dotnet-version: 5.0.x # SDK Version to use.
15+
dotnet-version: 6.0.x # SDK Version to use.
1616

1717
- name: Setup MSBuild
1818
uses: microsoft/[email protected]
1919
with:
20-
vs-version: 16.10 # Visual Studio Version to use.
20+
vs-version: 17.1 # Visual Studio Version to use.
2121

2222
- name: Setup VSTest
2323
uses: darenm/Setup-VSTest@v1
@@ -37,4 +37,4 @@ jobs:
3737
run: msbuild src/WebEid.Security.sln /t:Build /p:Configuration=Release
3838

3939
- name: Test
40-
run: vstest.console.exe src/WebEid.Security.Tests/bin/Release/net5.0/WebEID.Security.Tests.dll
40+
run: vstest.console.exe src/WebEid.Security.Tests/bin/Release/net6.0/WebEID.Security.Tests.dll

.github/workflows/sonarcloud-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Setup dotnet
1616
uses: actions/setup-dotnet@v1
1717
with:
18-
dotnet-version: 5.0.x # SDK Version to use.
18+
dotnet-version: 6.0.x # SDK Version to use.
1919

2020
- name: Set up JDK 11
2121
uses: actions/setup-java@v1

README.md

Lines changed: 163 additions & 166 deletions
Large diffs are not rendered by default.

src/WebEid.Security.Tests/TestUtils/AuthTokenValidators.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public static IAuthTokenValidator GetAuthTokenValidator() =>
1515
public static IAuthTokenValidator GetAuthTokenValidator(string url) =>
1616
GetAuthTokenValidator(url, GetCaCertificates());
1717

18-
public static IAuthTokenValidator GetAuthTokenValidator(string url, params X509Certificate[] certificates) =>
18+
public static IAuthTokenValidator GetAuthTokenValidator(string url, params X509Certificate2[] certificates) =>
1919
GetAuthTokenValidatorBuilder(url, certificates)
2020
// Assure that all builder methods are covered with tests.
2121
.WithOcspRequestTimeout(TimeSpan.FromSeconds(1))
@@ -41,12 +41,12 @@ public static IAuthTokenValidator GetAuthTokenValidatorWithDisallowedEsteidPolic
4141
.WithDisallowedCertificatePolicies(EstIdemiaPolicy)
4242
.Build();
4343

44-
private static AuthTokenValidatorBuilder GetAuthTokenValidatorBuilder(string uri, X509Certificate[] certificates) =>
44+
private static AuthTokenValidatorBuilder GetAuthTokenValidatorBuilder(string uri, X509Certificate2[] certificates) =>
4545
new AuthTokenValidatorBuilder()
4646
.WithSiteOrigin(new Uri(uri))
4747
.WithTrustedCertificateAuthorities(certificates);
4848

49-
private static X509Certificate[] GetCaCertificates() =>
49+
private static X509Certificate2[] GetCaCertificates() =>
5050
Certificates.CertificateLoader.LoadCertificatesFromResources("TEST_of_ESTEID2018.cer");
5151
}
5252
}

src/WebEid.Security.Tests/Validator/AuthTokenValidationConfigurationTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void AuthTokenValidationConfigurationWithZeroOcspRequestTimeoutThrowsArgu
4848
{
4949
SiteOrigin = new Uri("https://valid", UriKind.RelativeOrAbsolute),
5050
};
51-
configuration.TrustedCaCertificates.Add(new X509Certificate2());
51+
configuration.TrustedCaCertificates.Add(new X509Certificate2(Array.Empty<byte>()));
5252
configuration.OcspRequestTimeout = TimeSpan.Zero;
5353
Assert.Throws<ArgumentOutOfRangeException>(() => configuration.Validate())
5454
.WithMessage("OCSP request timeout must be greater than zero (Parameter 'ocspRequestTimeout')");
@@ -61,7 +61,7 @@ public void AuthTokenValidationConfigurationWithCorrectDataDoesNotThrowException
6161
{
6262
SiteOrigin = new Uri("https://valid", UriKind.RelativeOrAbsolute),
6363
};
64-
configuration.TrustedCaCertificates.Add(new X509Certificate2());
64+
configuration.TrustedCaCertificates.Add(new X509Certificate2(Array.Empty<byte>()));
6565
Assert.DoesNotThrow(() => configuration.Validate());
6666
}
6767

src/WebEid.Security.Tests/WebEid.Security.Tests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<Project Sdk="Microsoft.NET.Sdk">
22

33
<PropertyGroup>
4-
<TargetFramework>net5.0</TargetFramework>
4+
<TargetFramework>net6.0</TargetFramework>
55

66
<IsPackable>false</IsPackable>
77

src/WebEid.Security/Validator/AuthTokenValidatorBuilder.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ public AuthTokenValidatorBuilder WithSiteOrigin(Uri origin)
3636
/// </summary>
3737
/// <param name="certificates">trusted intermediate Certificate Authority certificates</param>
3838
/// <returns>the builder instance for method chaining</returns>
39-
public AuthTokenValidatorBuilder WithTrustedCertificateAuthorities(params X509Certificate[] certificates)
39+
public AuthTokenValidatorBuilder WithTrustedCertificateAuthorities(params X509Certificate2[] certificates)
4040
{
41-
this.configuration.TrustedCaCertificates.AddRange(certificates.Select(c => new X509Certificate2(c)));
41+
this.configuration.TrustedCaCertificates.AddRange(certificates);
4242
this.logger?.LogDebug("Trusted intermediate certificate authorities set to {0}",
4343
this.configuration.TrustedCaCertificates.Select(c => c.GetSubjectCn()));
4444
return this;

src/WebEid.Security/Validator/Ocsp/OcspRequestBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ private void AddNonce(OcspReqGenerator builder)
5959
{
6060
this.Nonce = new byte[8];
6161

62-
using (var rndGenerator = RNGCryptoServiceProvider.Create())
62+
using (var rndGenerator = RandomNumberGenerator.Create())
6363
{
6464
rndGenerator.GetBytes(this.Nonce);
6565
}

src/WebEid.Security/WebEid.Security.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
<Description>Web eID authentication token validation library</Description>
55
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
66
<PackageReleaseNotes>Release</PackageReleaseNotes>
7-
87
<TargetFramework>netstandard2.1</TargetFramework>
98
<RootNamespace>WebEid.Security</RootNamespace>
109
<AssemblyName>WebEid.Security</AssemblyName>
10+
<PublisherName>RIA</PublisherName>
11+
<Authors>RIA</Authors>
12+
<Copyright>RIA</Copyright>
1113
</PropertyGroup>
1214

1315
<ItemGroup>

0 commit comments

Comments
 (0)