Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Output Pattern #310

Open
finalfantasia opened this issue Jul 18, 2023 · 2 comments
Open

Custom Output Pattern #310

finalfantasia opened this issue Jul 18, 2023 · 2 comments

Comments

@finalfantasia
Copy link

finalfantasia commented Jul 18, 2023

It would be great if cljfmt supported custom output pattern so that it can be better integrated with GitHub Actions. clj-kondo supports this and it makes problem reporting much nicer.

@weavejester
Copy link
Owner

That's a very good idea. I'll look into adding it when I get a little time (which should be faiiirly soon).

@weavejester
Copy link
Owner

Looks like this is more difficult to support than it initially appears, at least if we want to get reasonable output. Multi-line support requires URL-escaping the log message, for example, and ideally we'd want to give each chunk of the diff its own warning message with a start and end line number.

I don't think a custom output pattern by itself would be sufficient; we'd probably need a dedicated GitHub reporter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants