New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP: Require or disallow trailing comma in functions #214

Open

ocean90 opened this issue Apr 13, 2023 · 2 comments

Labels

php question

Member

ocean90 commented Apr 13, 2023

Option 1:

sprintf(
	'Foo %s',
	'bar',
);

Sniffs:
SlevomatCodingStandard.Functions.RequireTrailingCommaInCall
SlevomatCodingStandard.Functions.RequireTrailingCommaInClosureUse
SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration

Option 2:

sprintf(
	'Foo %s',
	'bar'
);

Sniffs:
SlevomatCodingStandard.Functions.DisallowTrailingCommaInCall
SlevomatCodingStandard.Functions.DisallowTrailingCommaInClosureUse
SlevomatCodingStandard.Functions.DisallowTrailingCommaInDeclaration

Related: https://php.watch/versions/8.0/trailing-comma-parameter-use-list

The text was updated successfully, but these errors were encountered:

ocean90 added question php labels

Member

derpaschi commented Apr 13, 2023

+1 for Option 1

nuritnt commented Apr 14, 2023 •

edited

Loading

Option 3: 🤭

sprintf(
	'Foo %s'
	, 'bar'
        , 'baz'
);

+1 for Option 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment