🎯 fix: Cart button was not working on smaller screens #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devAsadNur
changed the title
ashrafuzzaman93
approved these changes
Mar 13, 2024
|
Issue: Solution for this PR was to redirect user to cart page when user clicks on cart icon. This is working, but the issue is, it is also opening the mini cart modal and then redirecting user to cart page. This is not an ideal for user experience. Suggested Solution: Once user clicks on the cart button on mobile view, either redirect to cart page or only open the mini cart modal. @devAsadNur bhai FYI @mrabbani bhai |
|
Relevant with mini cart preview loading pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cart button was not working on smaller screens.
Now, fixed the issue by this PR.