fix rest_pre_serve_request error reported by user

Author: kilbot

includes/API.php

@@ -102,16 +102,24 @@ public function rest_allowed_cors_headers( array $allow_headers ): array {
 
 	/**
 	 * Add Access Control Allow Headers for POS app.
+     *
+     * NOTE: I have seen this filter called with NULL for $served, which is not expected
 	 *
-	 * @param bool             $served  Whether the request has already been served.
+	 * @param mixed            $served  Whether the request has already been served.
 	 *                                  Default false.
 	 * @param WP_HTTP_Response $result  Result to send to the client. Usually a `WP_REST_Response`.
 	 * @param WP_REST_Request  $request Request used to generate the response.
 	 * @param WP_REST_Server   $server  Server instance.
 	 *
 	 * @return bool $served
 	 */
-	public function rest_pre_serve_request( bool $served, WP_HTTP_Response $result, WP_REST_Request $request, WP_REST_Server $server ): bool {
+	public function rest_pre_serve_request( $served, WP_HTTP_Response $result, WP_REST_Request $request, WP_REST_Server $server ): bool {
+        // Check if served is a boolean
+        if ( ! is_bool( $served ) ) {
+            Logger::log( "Warning: 'rest_pre_serve_request' filter received a non-boolean value for 'served'. Defaulting to 'false'." );
+            $served = false; // Default value if not provided correctly
+        }
+        
 		$server->send_header( 'Access-Control-Allow-Origin', '*' );
 
 		return $served;
@@ -193,6 +201,12 @@ public function get_auth_header() {
 			$header = sanitize_text_field( $_SERVER['REDIRECT_HTTP_AUTHORIZATION'] );
 		}
 
+        // Check for authorization param in URL
+        // @TODO - add setting to enable this
+        if ( ! $header && isset( $_GET['authorization'] ) ) {
+            $header = sanitize_text_field( $_GET['authorization'] );
+        }
+
 		return $header;
 	}
 

readme.txt

@@ -63,6 +63,9 @@ There is more information on our website at [https://wcpos.com](https://wcpos.co
 
 == Changelog ==
 
+= 1.3.6 = 2023/07/ =
+* Fix: rest_pre_serve_request critical error reported by some users
+
 = 1.3.4 and 1.3.5 - 2023/07/29 =
 * Urgent Fix: product descriptions being truncated to 100 characters