Skip to content

Commit 416caf9

Browse files
committed
use json_params in settings update
1 parent b62ec7c commit 416caf9

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Setup PHP with tools
2222
uses: shivammathur/setup-php@v2
2323
with:
24-
php-version: "7.3"
24+
php-version: "7.4"
2525
tools: composer, cs2pr, phpcs
2626

2727
- name: Build

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"dealerdirect/phpcodesniffer-composer-installer": true
3838
},
3939
"platform": {
40-
"php": "7.3"
40+
"php": "7.4"
4141
}
4242
},
4343
"scripts": {

includes/API/Settings.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ public function get_payment_gateways_settings() {
415415
* @return array|WP_Error
416416
*/
417417
public function update_payment_gateways_settings( WP_REST_Request $request ) {
418-
$settings = array_replace_recursive( $this->get_payment_gateways_settings(), $request->get_params() );
418+
$settings = array_replace_recursive( $this->get_payment_gateways_settings(), $request->get_json_params() );
419419
return $this->save_settings( 'payment_gateways', $settings );
420420
}
421421

@@ -427,7 +427,7 @@ public function update_payment_gateways_settings( WP_REST_Request $request ) {
427427
* @return array|WP_Error
428428
*/
429429
public function update_general_settings( WP_REST_Request $request ) {
430-
$settings = array_replace_recursive( $this->get_general_settings(), $request->get_params() );
430+
$settings = array_replace_recursive( $this->get_general_settings(), $request->get_json_params() );
431431
return $this->save_settings( 'general', $settings );
432432
}
433433

@@ -460,7 +460,7 @@ public function get_general_settings(): array {
460460
* @return array|WP_Error
461461
*/
462462
public function update_checkout_settings( WP_REST_Request $request ) {
463-
$settings = array_replace_recursive( $this->get_checkout_settings(), $request->get_params() );
463+
$settings = array_replace_recursive( $this->get_checkout_settings(), $request->get_json_params() );
464464
return $this->save_settings( 'checkout', $settings );
465465
}
466466

@@ -494,7 +494,7 @@ public function get_checkout_settings(): array {
494494
*/
495495
public function update_access_settings( WP_REST_Request $request ) {
496496
global $wp_roles;
497-
$data = $request->get_params();
497+
$data = $request->get_json_params();
498498

499499
// get all role slugs
500500
$roles = array_keys( $wp_roles->roles );

packages/settings/src/screens/checkout/gateways.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ const Gateways = () => {
146146
type="radio"
147147
value={item.id}
148148
checked={data?.default_gateway === item.id}
149+
disabled={!item.enabled}
149150
className=""
150151
onChange={() => {
151152
mutate({ default_gateway: item.id });

0 commit comments

Comments
 (0)