Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative line links? #7

Open
gitblit opened this issue Feb 10, 2016 · 3 comments · May be fixed by #15
Open

Relative line links? #7

gitblit opened this issue Feb 10, 2016 · 3 comments · May be fixed by #15
Labels
enhancement

Comments

@gitblit
Copy link

gitblit commented Feb 10, 2016

This looks like a nice enhancement for what I consider to be missing functionality in highlight.js. Not every one agrees, but that's ok.

Is there a way your plugin could optionally generate relative line links? something like <a href="#line100">100</a> ?
@wcoder
Copy link
Owner

wcoder commented Feb 10, 2016

Thanks, it is great idea!

Currently, I investigate this functionality.

wcoder added a commit that referenced this issue Feb 10, 2016
@wcoder
Added implementation of relative links #7
883ba5d
wcoder added a commit that referenced this issue Feb 11, 2016
@wcoder
Replaced id to name #7
996655c
@wcoder wcoder mentioned this issue Feb 29, 2016
Closed
@wcoder
Copy link
Owner

wcoder commented Mar 1, 2016

@gitblit, what do you think about this implementation?

Wilfred pushed a commit to Wilfred/highlightjs-line-numbers.js that referenced this issue Feb 27, 2017
@wcoder @Wilfred
Added implementation of relative links wcoder#7
6f88ece
@Wilfred Wilfred linked a pull request Feb 27, 2017 that will close this issue
Open
@johngilden
Copy link

Would be really cool to get this merged into the latest version somehow!

@llmII llmII mentioned this issue Jul 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added implementation of relative links #7 Wilfred/highlightjs-line-numbers.js
3 participants
@wcoder @gitblit @johngilden