Skip to content

feat: print total time taken to load all plugins #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: print total time taken to load all plugins #884

wants to merge 3 commits into from

Conversation

@mawkler
Copy link
Contributor

@mawkler mawkler commented Apr 21, 2022

No description provided.

wbthomason
wbthomason requested changes Jul 26, 2022
View reviewed changes
Copy link
Owner

@wbthomason wbthomason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this will be a good addition; I'd just like some small changes to keep things clean and consistent before we merge.

@mawkler
Copy link
Contributor Author

mawkler commented Jul 26, 2022 •
edited
Loading

Thanks for your feedback! I've updated the PR accordingly. I've also moved the threshold message to #984 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbthomason wbthomason wbthomason requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mawkler @wbthomason