Skip to content
This repository has been archived by the owner on Mar 28, 2024. It is now read-only.

Merge pull request #66 from wbcsd/test-typo #75

Merged

Conversation

JohnDevitt
Copy link
Contributor

No description provided.

fix: typo in tested_by.solution_id
@vercel
Copy link

vercel bot commented Sep 18, 2023

@raimundo-henriques is attempting to deploy a commit to the wbcsd Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pact-catalog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 10:42am

@raimundo-henriques
Copy link
Contributor

raimundo-henriques commented Sep 19, 2023

@JohnDevitt,
I took the liberty of committing directly on your branch to fix what seemed to be a typo: Altruistiq's solution in the catalog has version 2.0.0, rather than 1.0.0.
Can you please confirm if you agree with this change?
Thank you,
Best,

cc. @prasadt1

@JohnDevitt
Copy link
Contributor Author

@JohnDevitt, I took the liberty of committing directly on your branch to fix what seemed to be a typo: Altruistiq's solution in the catalog has version 2.0.0, rather than 1.0.0. Can you please confirm if you agree with this change? Thank you, Best,

cc. @prasadt1

We've implemented v2 at co2ai and we tested Altrusitiq for v2 also. Both of these should be v2 IMO.

@raimundo-henriques
Copy link
Contributor

@JohnDevitt , do you mean the version of the technical specifications? That one is identified in the "pathfinder_version" field and it's indeed 2.0.1.

My change concerned the version of Altruistiq's solution. Each solution ("tested_solution" and "tested_by", that is) includes a "version" field that identifies the version of the solution. Altruistiq's solution in the catalog is identified as version 2.0.0 (as indicated in their solution name), but the value of the "version" field was 1.0.0, hence my change.

Thank you!

@JohnDevitt
Copy link
Contributor Author

JohnDevitt commented Sep 19, 2023

@JohnDevitt , do you mean the version of the technical specifications? That one is identified in the "pathfinder_version" field and it's indeed 2.0.1.

My change concerned the version of Altruistiq's solution. Each solution ("tested_solution" and "tested_by", that is) includes a "version" field that identifies the version of the solution. Altruistiq's solution in the catalog is identified as version 2.0.0 (as indicated in their solution name), but the value of the "version" field was 1.0.0, hence my change.

Thank you!

Apologies, right you are.

We're also v1, so I've added another commit to fix that. We're all good to go now I believe :)

@raimundo-henriques
Copy link
Contributor

I'm glad we could clarify it! Thank you for your quick responses!
We will merge your PR right away

@raimundo-henriques raimundo-henriques merged commit 1ee9d56 into wbcsd:main Sep 19, 2023
3 checks passed
@JohnDevitt JohnDevitt deleted the add-co2ai-solution-to-catalog branch September 19, 2023 11:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants