Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose up -d vs. docker compose up -d #7444

Open
schneich opened this issue Jun 22, 2024 · 2 comments
Open

docker-compose up -d vs. docker compose up -d #7444

schneich opened this issue Jun 22, 2024 · 2 comments
Assignees

Comments

@schneich
Copy link

schneich commented Jun 22, 2024

Dear Wazuh-Team,

please change the docker documentation: https://documentation.wazuh.com/current/deployment-options/docker/wazuh-container.html

docker-compose up -d (dash between docker and compose) uses the old engine, where as docker compose up -d is the new one, where all features are supported.

Thank you,
Chris

Edit: source: https://docs.docker.com/compose/migrate/

@schneich
Copy link
Author

schneich commented Jun 22, 2024

Two more things:

  • please include a top level name into the compose.yaml
  • please remove the version number in the compose.yaml

Example:

# Wazuh App Copyright (C) 2017, Wazuh Inc. (License GPLv2)
name: wazuh

services:
  wazuh.manager:
    image: wazuh/wazuh-manager:4.8.0
    container_name: manager
    hostname: wazuh.manager
    ...

@rauldpm rauldpm self-assigned this Jun 26, 2024
@rauldpm
Copy link
Member

rauldpm commented Jun 26, 2024

Hi @schneich

docker-compose up -d (dash between docker and compose) uses the old engine, where as docker compose up -d is the new one, where all features are supported.

We are already aware of this and we have this issue in our roadmap wazuh/wazuh-docker#1314


About the following points:

please include a top level name into the compose.yaml
please remove the version number in the compose.yaml

I suggest you open an issue in the wazuh-docker repository so the team can analyze it and work on it if it is accepted, we need to test it and check if the functionality is affected, as Docker upgrades usually

  • https://docs.docker.com/compose/compose-file/04-version-and-name/

    The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative and you'll receive a warning message that it is obsolete if used.

    Compose doesn't use version to select an exact schema to validate the Compose file, but prefers the most recent schema when it's implemented.

    Compose validates whether it can fully parse the Compose file. If some fields are unknown, typically because the Compose file was written with fields defined by a newer version of the Specification, you'll receive a warning message.

Keep in mind that certain Docker upgrades maintain the old docker-compose files https://documentation.wazuh.com/current/deployment-options/docker/upgrading-wazuh-docker.html#keeping-custom-docker-compose-files, so those new additions will not be present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants