-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage test fix #420
Closed
jr0me
wants to merge
31
commits into
master
from
enhancement/167-platform-abstraction-layer-rebase-test
Closed
Coverage test fix #420
jr0me
wants to merge
31
commits into
master
from
enhancement/167-platform-abstraction-layer-rebase-test
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `getCommandFromQueue` function has been updated to parse commands according to the new definition. Additionally, the related tests have been fixed.
A function is added to validate commands, ensuring their arguments are also valid when required, and assigning the corresponding module. A map is created containing the valid commands, their associated module, and whether argument validation is needed.
The argument parsing method in the centralized configuration is updated, and the related tests are fixed.
The mock server created with Imposter has been updated with the latest changes related to commands. Some test cases have been added.
The timeout implementation for command tasks has been fixed. A segmentation fault occurred due to shared usage of the timer.
The ModuleManager start runs its own task manager and is not blocking, so it doesnt need to be run on a separate thread
…several warnings regarding -static-libstdc++
jr0me
deleted the
enhancement/167-platform-abstraction-layer-rebase-test
branch
December 12, 2024 22:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing merging the PAL request with PR #408