Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if the http client library is closing sockets as expected #564

Open
3 tasks
TomasTurina opened this issue Jan 30, 2025 · 0 comments
Open
3 tasks
Labels

Comments

@TomasTurina
Copy link
Member

Description

The http client library uses Boost Beast's HTTP and HTTPS sockets to execute requests.

Every time a new request is executed, a new socket is created which is used to create the communication with the server.

Additionally, sockets have a Close function which must be called at the end of the operation to properly close the socket. However, this function is not currently being used and needs to be evaluated.

Tasks

  • Investigate the use of the Close socket functions and in which cases they should be called.
  • If necessary, adapt the current http client code to use them.
  • Be sure to test this change on all supported operating systems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant