Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for agent self-restarting on Linux #438

Closed
2 of 3 tasks
Tracked by #54
MarcelKemp opened this issue Dec 17, 2024 · 2 comments · Fixed by #547
Closed
2 of 3 tasks
Tracked by #54

Add testing for agent self-restarting on Linux #438

MarcelKemp opened this issue Dec 17, 2024 · 2 comments · Fixed by #547
Assignees
Labels

Comments

@MarcelKemp
Copy link
Member

MarcelKemp commented Dec 17, 2024

Parent issue:

Description

Develop unit tests to validate the agent's ability to recognize and process the self-restart command. (Reference issue #77 for considerations on updating any broken unit tests.)

Tasks

  • Develop and execute unit tests for the new functionality.
  • Update the unit-test that was broken by the implementation
  • Perform integration tests to ensure the command works across different environments.
@lchico lchico self-assigned this Dec 17, 2024
@lchico lchico added level/task Task issue type/enhancement Enhancement issue module/agent labels Dec 17, 2024
@lchico
Copy link
Member

lchico commented Dec 18, 2024

2024-12-17

  • I started working on this and researched the argument implementation used to recognize the command and arguments for starting the Wazuh agent service, causing some unit tests to break.

2024-12-18

  • Review the command handler flow.
  • Restructure the self-restart code.

2024-12-19

  • Due to significant changes in the implementation, I have blocked further progress. Resuming work on the development issue.

@wazuhci wazuhci moved this to Blocked in XDR+SIEM/Release 5.0.0 Dec 27, 2024
@wazuhci wazuhci moved this from Blocked to In progress in XDR+SIEM/Release 5.0.0 Jan 23, 2025
@lchico
Copy link
Member

lchico commented Jan 23, 2025

Update

  • Began working on the new code.
  • Set up the test project and ran the first test.

2025-01-23

  • I made minor changes to the code to simplify the test. Pushed some tests to the branch, but I still need to address a couple more tests.

2025-01-24

  • Rebased with the base branch, updated some tests, generated new tests, and pending fixing some issues with Windows and macOS.
  • Created a PR with the results.

2025-01-25

  • I rebased with the base branch and updated some tests to resolve the issues with Windows and macOS.
  • Left the PR ready for review.

@lchico lchico linked a pull request Jan 25, 2025 that will close this issue
@wazuhci wazuhci moved this from In progress to Pending review in XDR+SIEM/Release 5.0.0 Jan 27, 2025
@MarcelKemp MarcelKemp changed the title Add support for agent self-restarting: Testing Phase Add testing for agent self-restarting on Linux Jan 28, 2025
@wazuhci wazuhci moved this from Pending review to In review in XDR+SIEM/Release 5.0.0 Jan 30, 2025
@wazuhci wazuhci moved this from In review to Done in XDR+SIEM/Release 5.0.0 Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants